Skip to content
This repository has been archived by the owner on Feb 8, 2024. It is now read-only.

#65 - moved api call from rest to enterprise #195

Merged
merged 4 commits into from
Mar 10, 2017
Merged

Conversation

VitoAlbano
Copy link
Contributor

Please check if the PR fulfills these requirements

[ ] The commit message follows our [guidelines](https://github.com/Alfresco/alfresco-js-ap/wiki/Commit-format)
[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] Documentation
[x] Other... Please describe: Enhancement for getTaskVariables using now the enterprise api

What is the current behavior? (You can also link to an open issue here)
actually we use rest api for {taskId}/variables

What is the new behavior?
We changed the rest api to the enterprise call /api/enterprise/tasks/{taskId}/variables

Does this PR introduce a breaking change? (check one with "x")

[ ] Yes
[x] No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:
Before merge this PR it needs to be checked against the visibility engine of ADF to avoid regressions.

@codecov-io
Copy link

codecov-io commented Mar 7, 2017

Codecov Report

Merging #195 into development will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff              @@
##           development     #195   +/-   ##
============================================
  Coverage        91.37%   91.37%           
============================================
  Files               11       11           
  Lines              545      545           
  Branches            68       68           
============================================
  Hits               498      498           
  Misses              47       47

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c660c74...13e9b4d. Read the comment docs.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 91.051% when pulling e7db366 on dev-valbano-65 into e6a5990 on development.

@eromano
Copy link
Contributor

eromano commented Mar 10, 2017

can you modify the changelog?

@coveralls
Copy link

Coverage Status

Coverage remained the same at 91.051% when pulling bb490c8 on dev-valbano-65 into e6a5990 on development.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 91.051% when pulling bb490c8 on dev-valbano-65 into e6a5990 on development.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 91.398% when pulling 623fc5a on dev-valbano-65 into c660c74 on development.

@eromano eromano merged commit 9dc0d05 into development Mar 10, 2017
eromano pushed a commit that referenced this pull request Mar 30, 2017
#65 - moved api call from rest to enterprise
@eromano eromano mentioned this pull request Mar 30, 2017
mauriziovitale pushed a commit that referenced this pull request Apr 4, 2017
* 1.2.2 build

* 1.2.2 build

* #65 - moved api call from rest to enterprise (#195)

#65 - moved api call from rest to enterprise

* Search API (#198)

#194 search api

* Alfresco authoraization server support (#202)

* fix authentication reference
oauth2 spike

* add oauth2 option

* Oauth2 support documentation and refresh token

* changelog

* fix interface auth (#203)

improve validation

* add  maxItems and skipCount as options in findSharedLinks #200 (#204)

* Move the build process from browserify to webpack #206 (#207)

* 1.3.0 build
@VitoAlbano VitoAlbano deleted the dev-valbano-65 branch April 11, 2017 12:42
eromano pushed a commit that referenced this pull request Apr 26, 2017
#65 - moved api call from rest to enterprise
magemello pushed a commit that referenced this pull request Apr 27, 2017
#65 - moved api call from rest to enterprise
eromano pushed a commit that referenced this pull request May 26, 2017
#65 - moved api call from rest to enterprise
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants