Skip to content
This repository has been archived by the owner on Feb 8, 2024. It is now read-only.

fix build issues #353

Merged
merged 1 commit into from Aug 6, 2018
Merged

fix build issues #353

merged 1 commit into from Aug 6, 2018

Conversation

eromano
Copy link
Contributor

@eromano eromano commented Aug 6, 2018

remove validation client side

Please check if the PR fulfills these requirements

[x] The commit message follows our [guidelines](https://github.com/Alfresco/alfresco-js-api/wiki/Commit-format)
[x] Tests for the changes have been added (for bug fixes / features)
[x] Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] Documentation
[ ] Other... Please describe:

What is the current behavior? (You can also link to an open issue here)
Remove Comments
Remove Validation

What is the new behavior?

Does this PR introduce a breaking change? (check one with "x")

[x] Yes
[ ] No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

remove validation client side
@codecov-io
Copy link

codecov-io commented Aug 6, 2018

Codecov Report

Merging #353 into development will decrease coverage by 0.28%.
The diff coverage is 0%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development     #353      +/-   ##
===============================================
- Coverage        71.53%   71.25%   -0.29%     
===============================================
  Files               23       23              
  Lines             1370     1374       +4     
  Branches           263      261       -2     
===============================================
- Hits               980      979       -1     
- Misses             390      395       +5
Impacted Files Coverage Δ
src/oauth2Auth.js 37.3% <0%> (-0.78%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5acbab...64c2ab9. Read the comment docs.

@eromano eromano merged commit bafd6cb into development Aug 6, 2018
eromano added a commit that referenced this pull request Aug 10, 2018
remove validation client side
@DenysVuika DenysVuika deleted the dev-eromano-commentsstrip branch August 14, 2018 13:29
eromano added a commit that referenced this pull request Aug 14, 2018
* add missing search typings (#328)

* Update index.d.ts

* Update index.d.ts

* fix enums usage/imports in TypeScript (#329)

* fix enums usage/imports in TypeScript

* enum fixes

* update test script

* test against release (master)

* Revert "test against release (master)"

This reverts commit 7e2a9b1.

* restore the script

* use master for tests

* temp workaround for sort enum

* [ADF-2563] Update node content (#331)

* Update node content

* change log update

* [ADF-3037] Add newly introduced isFavorite property to Nodes (#332)

* add new isFavorite property

* update changelog

* [ADF-2573] remove duplicate listeners and add error event (#333)

* remove duplicate listeners
add error event

* test error handler

* [ADF-2481] disable timeout (#334)

* disable timeout

* changelog

* change timeout settings

* fix typings error

* remove non-existing parameter

* missing property on declaration

* remove client timeout

* added nodeId property (#335)

* [ADF-2603] getVersionContent type definition missing parameters (#336)

* update versioning typings

* update changelog

* [ADF-SSO] Implicit flow login for oauth2 sso (#337)

* implicit flow oauth2

* oauth part 2

* check valid access token

* silent refresh token

* fix refresh token remove

* clean local token after logout

* documentation

* fix test

* improve storage

* add scope as required parameter add more test

* skip login form

* storage static

* init storage

* fix declaration file

* fix storage

* improve implicit flow using session storage

* redirect logout optional

* make check provider methods public

* remove trailing white space

* skipLoginForm rename to silentLogin

* remove secret mandatory

* fix declaration and implicit login

* create configuration change option

* fix metadata context
update changelog

* fix oauth2 hash problems (#339)

* authType property

* fix check islogin

* [ADF-3224] move logic store ticket in alfresco-js-api (#341)

* invalidate session

* changelog add

* invalidate session at logout

* rename clear storage in invalidateSession

* invalidate not oauth2 sessions only if needed

* missing space

* move to local storage

* exclude logout emc/bpm in oauth

* Fix type definition for TaskFormsApi.getTaskFormVariables (#342)

* [ADF-3184] grant type password KEYCLOAK fix

* Dev build fix (#345)

* fix travis script

* fix test and build

* travis script new conf

* Enforce the isBpm/isEcm loggedIn method checking the current provider… (#344)

* Enforce the isBpm/isEcm loggedIn method checking the current provider (BPM/ECM/ALL)

* Update alfrescoApi.js

* fix reference problem isEcmBpmConfiguration

* bump version

* [ADF-3289] AppsDefinitionApi contains two methods with same name and different firms (#347)

* remove duplicate methods firms

* changelog

* fix travis pipeline

* [ADF-3366] update Site details (#351)

* update site details

* update changelog

* update

* [ADF-3214] path element fixes (#352)

* [ADF-3383] Incorrect datatype for password in PersonBodyCreate in index.d.ts

* add missing path element properties

* update changelog

* remove comments (#353)

remove validation client side

* add updatePerson to peopleApi (#354)

* fix upload properties for multipart data (#355)

* 2.5.0 (#356)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants