This repository has been archived by the owner on Feb 8, 2024. It is now read-only.
[ADF-3538] added access token storaging for no implicit flow behaviour #371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eromano
pushed a commit
that referenced
this pull request
Oct 4, 2018
eromano
added a commit
that referenced
this pull request
Oct 4, 2018
* add missing search typings (#328) * Update index.d.ts * Update index.d.ts * fix enums usage/imports in TypeScript (#329) * fix enums usage/imports in TypeScript * enum fixes * update test script * test against release (master) * Revert "test against release (master)" This reverts commit 7e2a9b1. * restore the script * use master for tests * temp workaround for sort enum * [ADF-2563] Update node content (#331) * Update node content * change log update * [ADF-3037] Add newly introduced isFavorite property to Nodes (#332) * add new isFavorite property * update changelog * [ADF-2573] remove duplicate listeners and add error event (#333) * remove duplicate listeners add error event * test error handler * [ADF-2481] disable timeout (#334) * disable timeout * changelog * change timeout settings * fix typings error * remove non-existing parameter * missing property on declaration * remove client timeout * added nodeId property (#335) * [ADF-2603] getVersionContent type definition missing parameters (#336) * update versioning typings * update changelog * [ADF-SSO] Implicit flow login for oauth2 sso (#337) * implicit flow oauth2 * oauth part 2 * check valid access token * silent refresh token * fix refresh token remove * clean local token after logout * documentation * fix test * improve storage * add scope as required parameter add more test * skip login form * storage static * init storage * fix declaration file * fix storage * improve implicit flow using session storage * redirect logout optional * make check provider methods public * remove trailing white space * skipLoginForm rename to silentLogin * remove secret mandatory * fix declaration and implicit login * create configuration change option * fix metadata context update changelog * fix oauth2 hash problems (#339) * authType property * fix check islogin * [ADF-3224] move logic store ticket in alfresco-js-api (#341) * invalidate session * changelog add * invalidate session at logout * rename clear storage in invalidateSession * invalidate not oauth2 sessions only if needed * missing space * move to local storage * exclude logout emc/bpm in oauth * Fix type definition for TaskFormsApi.getTaskFormVariables (#342) * [ADF-3184] grant type password KEYCLOAK fix * Dev build fix (#345) * fix travis script * fix test and build * travis script new conf * Enforce the isBpm/isEcm loggedIn method checking the current provider… (#344) * Enforce the isBpm/isEcm loggedIn method checking the current provider (BPM/ECM/ALL) * Update alfrescoApi.js * fix reference problem isEcmBpmConfiguration * bump version * [ADF-3289] AppsDefinitionApi contains two methods with same name and different firms (#347) * remove duplicate methods firms * changelog * fix travis pipeline * [ADF-3366] update Site details (#351) * update site details * update changelog * update * [ADF-3214] path element fixes (#352) * [ADF-3383] Incorrect datatype for password in PersonBodyCreate in index.d.ts * add missing path element properties * update changelog * add updatePerson to peopleApi (#354) * fix wrong property check * correctly resolve object values in properties (#360) * new build stages (#361) * [ADF-3531] Fix the silent refresh login (#363) * create a different login url in case of silent iframe * in case of externalHash we should not check the isValidAccessToken and cancel the hash * attach the silentIframe even in case the token is valid. * - Use the window.location.origin as default redirectSilentIframeUri - Remove the tokens from the iframe hash - Destroy the iframe after the use * Change the path of the static page * Add doc related to the new property redirectSilentIframeUri * Update CHANGELOG.md * [ADF-3552] OAuth - Should not remove the hash part if is a valid route (#364) * Should not remove the hash part if is a valid route * fix error on method startWithHash * Update CHANGELOG.md * [ADF-3499] added domainPrefix for ecm ticket to be saved on local sto… (#366) * [ADF-3499] added domainPrefix for ecm ticket to be saved on local storage * [ADF-3499] updated CHANGELOG * typyngs versioncomment (#362) * The OauthApi interface should expose the callApi method to avoid error at build time (#368) * Add callCustomApi to index.d.ts (#369) * fix build (#370) * fix d.ts fix demo shell script * fix lint problem * stick version webpack-cli * [ADF-3538] added access token storaging for no implicit flow behaviour (#371) * Fix thrown error when using Oauth2's logOut method (#372) * 2.6.0 update version * Update CHANGELOG.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x")
What is the current behavior? (You can also link to an open issue here)
When not enabled implicit flow access token is never stored in the local storage. This makes the guard considering you not logged in when a refresh of the page happen
What is the new behavior?
We have added the store and retrieve of the access token when implict flow is disabled.
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information: