AAE-20282 fix submit button enabled when required people/groups widge…

…t empty (#9334)
Alfresco · Feb 14, 2024 · 1b3b419 · 1b3b419
1 parent 2175b4b
commit 1b3b419
Show file tree

Hide file tree

Showing 4 changed files with 40 additions and 6 deletions.
diff --git a/lib/process-services-cloud/src/lib/form/components/widgets/group/group-cloud.widget.spec.ts b/lib/process-services-cloud/src/lib/form/components/widgets/group/group-cloud.widget.spec.ts
@@ -130,6 +130,23 @@ describe('GroupCloudWidgetComponent', () => {
 
             expect(element.querySelector('.adf-invalid')).toBeTruthy();
         });
+
+        it('should be invalid after deselecting all groups', async () => {
+            widget.onChangedGroup([{id: 'test-id', name: 'test-name'}]);
+            fixture.detectChanges();
+            await fixture.whenStable();
+
+            expect(element.querySelector('.adf-error-text')).toBeFalsy();
+
+            const removeGroupIcon = element.querySelector('[data-automation-id="adf-cloud-group-chip-remove-icon-test-name"]');
+            removeGroupIcon.dispatchEvent(new Event('click'));
+
+            fixture.detectChanges();
+            await fixture.whenStable();
+
+            expect(element.querySelector('.adf-error-text')).toBeTruthy();
+            expect(element.querySelector('.adf-error-text').textContent).toContain('ADF_CLOUD_GROUPS.ERROR.NOT_FOUND');
+        });
     });
 
     describe('when is readOnly', () => {

diff --git a/lib/process-services-cloud/src/lib/form/components/widgets/group/group-cloud.widget.ts b/lib/process-services-cloud/src/lib/form/components/widgets/group/group-cloud.widget.ts
@@ -89,13 +89,13 @@ export class GroupCloudWidgetComponent extends WidgetComponent implements OnInit
             });
     }
 
-    ngOnDestroy() {
+    ngOnDestroy(): void {
         this.onDestroy$.next(true);
         this.onDestroy$.complete();
     }
 
-    onChangedGroup(groups) {
-        this.field.value = [...groups];
+    onChangedGroup(groups: IdentityGroupModel[]): void {
+        this.field.value = groups?.length ? [...groups] : null;
         this.onFieldChanged(this.field);
     }
 

diff --git a/...process-services-cloud/src/lib/form/components/widgets/people/people-cloud.widget.spec.ts b/...process-services-cloud/src/lib/form/components/widgets/people/people-cloud.widget.spec.ts
@@ -158,6 +158,23 @@ describe('PeopleCloudWidgetComponent', () => {
 
             expect(element.querySelector('.adf-invalid')).toBeTruthy();
         });
+
+        it('should be invalid after deselecting all people', async () => {
+            widget.onChangedUser([{id: 'test-id', username: 'test-name'}]);
+            fixture.detectChanges();
+            await fixture.whenStable();
+
+            expect(element.querySelector('.adf-error-text')).toBeFalsy();
+
+            const removeGroupIcon = element.querySelector('[data-automation-id="adf-people-cloud-chip-remove-icon-test-name"]');
+            removeGroupIcon.dispatchEvent(new Event('click'));
+
+            fixture.detectChanges();
+            await fixture.whenStable();
+
+            expect(element.querySelector('.adf-error-text')).toBeTruthy();
+            expect(element.querySelector('.adf-error-text').textContent).toContain('ADF_CLOUD_USERS.ERROR.NOT_FOUND');
+        });
     });
 
     describe('when is readOnly', () => {

diff --git a/lib/process-services-cloud/src/lib/form/components/widgets/people/people-cloud.widget.ts b/lib/process-services-cloud/src/lib/form/components/widgets/people/people-cloud.widget.ts
@@ -99,13 +99,13 @@ export class PeopleCloudWidgetComponent extends WidgetComponent implements OnIni
         }
     }
 
-    ngOnDestroy() {
+    ngOnDestroy(): void {
         this.onDestroy$.next(true);
         this.onDestroy$.complete();
     }
 
-    onChangedUser(users) {
-        this.field.value = [...users];
+    onChangedUser(users: IdentityUserModel[]): void {
+        this.field.value = users?.length ? [...users] : null;
         this.onFieldChanged(this.field);
     }