[AAE-6307] Setting a default process name (#7389)

* [AAE-6307] Setting a process name on init if process definition name is present * delete space and adding semicolon * fixed lint
Alfresco · Nov 29, 2021 · dbb7aef · dbb7aef
1 parent 32621f2
commit dbb7aef
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 5 deletions.
diff --git a/...ices-cloud/src/lib/process/start-process/components/start-process-cloud.component.spec.ts b/...ices-cloud/src/lib/process/start-process/components/start-process-cloud.component.spec.ts
@@ -827,6 +827,19 @@ describe('StartProcessCloudComponent', () => {
             expect(component.processInstanceName.value).toEqual('fake-transformed-name');
         });
 
+        it('should set the process name on init when a process definition name is present',  () => {
+            const processNameCloudPipe = TestBed.inject(ProcessNameCloudPipe);
+            const fakeTransformedName = 'fake-transformed-name';
+            spyOn(processNameCloudPipe, 'transform').and.returnValue(fakeTransformedName);
+
+            component.processDefinitionName = 'fake-name';
+            component.ngOnInit();
+
+            expect(component.processInstanceName.dirty).toBe(true);
+            expect(component.processInstanceName.touched).toBe(true);
+            expect(component.processInstanceName.value).toEqual(fakeTransformedName);
+        });
+
         it('should cancel bubbling a keydown event ()', () => {
             const escapeKeyboardEvent = new KeyboardEvent('keydown', { 'keyCode': ESCAPE } as any);
             fixture.debugElement.triggerEventHandler('keydown', escapeKeyboardEvent);

diff --git a/...-services-cloud/src/lib/process/start-process/components/start-process-cloud.component.ts b/...-services-cloud/src/lib/process/start-process/components/start-process-cloud.component.ts
@@ -144,6 +144,8 @@ export class StartProcessCloudComponent implements OnChanges, OnInit, OnDestroy
             this.processDefinition.setValue(this.processDefinitionName);
             this.processDefinition.markAsDirty();
             this.processDefinition.markAsTouched();
+
+            this.setDefaultProcessName(this.processDefinitionName);
         }
     }
 
@@ -384,15 +386,19 @@ export class StartProcessCloudComponent implements OnChanges, OnInit, OnDestroy
 
     processDefinitionSelectionChanged(processDefinition: ProcessDefinitionCloud) {
         if (processDefinition) {
-            const processInstanceDetails: ProcessInstanceCloud = { processDefinitionName: processDefinition.name };
-            const defaultProcessName = this.processNameCloudPipe.transform(this.name, processInstanceDetails);
-            this.processInstanceName.setValue(defaultProcessName);
-            this.processInstanceName.markAsDirty();
-            this.processInstanceName.markAsTouched();
+            this.setDefaultProcessName(processDefinition.name);
             this.processDefinitionSelection.emit(processDefinition);
         }
     }
 
+    setDefaultProcessName(processDefinitionName: string): void {
+        const processInstanceDetails: ProcessInstanceCloud = { processDefinitionName };
+        const defaultProcessName = this.processNameCloudPipe.transform(this.name, processInstanceDetails);
+        this.processInstanceName.setValue(defaultProcessName);
+        this.processInstanceName.markAsDirty();
+        this.processInstanceName.markAsTouched();
+    }
+
     ngOnDestroy() {
         this.onDestroy$.next(true);
         this.onDestroy$.complete();