New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin generated properties in finalName break the amp generation #286

Closed
skopf opened this Issue May 15, 2015 · 3 comments

Comments

Projects
None yet
3 participants
@skopf
Collaborator

skopf commented May 15, 2015

You can choose a custom name for the amp artifact and even use properties in this name by setting the <finalName> for the build:
<finalName>${project.artifactId}-custom</finalName>
But if the final name contains properties that are generated by a plugin like the noSnapshotVersion or the parsedVersion.* properties provided by the build-helper, then the amp generation is broken.

The Alfresco SDK generates two folders in /target, one with this property resolved and another folder where this property has not been resolved. The generated jar and the configuration are placed into different folders, and only one of them is packed into the amp.

The problem is that the Alfresco SDK does not handle these properties consistently. Some parts of the Alfresco SDK properly resolve this property (the amp generation and the target of the jar generation), while other parts of the SDK do not (copying the /config folder)

@mindthegab mindthegab added the bug label Aug 6, 2015

@mindthegab mindthegab self-assigned this Aug 6, 2015

@mindthegab mindthegab added this to the 2.2.0 milestone Aug 6, 2015

@mindthegab

This comment has been minimized.

Show comment
Hide comment
@mindthegab

mindthegab Aug 6, 2015

Contributor

Most of this logic will go away with the JAR support, I don't think we'll be able to fix this in a SP, rather fix it properly in the new version.

Contributor

mindthegab commented Aug 6, 2015

Most of this logic will go away with the JAR support, I don't think we'll be able to fix this in a SP, rather fix it properly in the new version.

@gravitonian

This comment has been minimized.

Show comment
Hide comment
@gravitonian
Contributor

gravitonian commented Jan 12, 2016

@gravitonian

This comment has been minimized.

Show comment
Hide comment
@gravitonian

gravitonian Jan 20, 2016

Contributor

fixed

Contributor

gravitonian commented Jan 20, 2016

fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment