@acset silently ignores nonexistent names

[filonik-cmu]

MWE

@acset Graph begin V = 2; E = 3; src = [1,1,1]; target = [2,2,2] end

[filonik-cmu]

Also, @acset silently ignores missing attributes (perhaps intentional), but subsequent migrations fail.

MWE

g₁ = @acset WeightedGraph{Float64} begin V = 2; E = 3; src = [1,1,1]; tgt = [2,2,2] end
g₂ = @migrate WeightedGraph{Float64} g₁ begin
  V => V
  E => E
  src => src
  tgt => tgt
  Weight => Weight
  weight => weight
end

[jpfairbanks]

Ohh, it took me a while to understand the problem because I was reading target as tgt. Yeah we should check that all the names exist in the initializer. How urgently do we want to work on this?

[filonik-cmu]

For me personally it is not as urgent as some of the other issues, but if they don't introduce any unforeseen consequences, I think these kinds of checks would be good for robustness/guarding against user errors.

[slwu89]

Closed with #110