New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend JSON3 write method for ACSets #78

Closed

jpfairbanks opened this issue Nov 9, 2023 · 1 comment

Assignees

Labels

enhancement good first issue

Member

jpfairbanks commented Nov 9, 2023

We should add

using JSON3
JSON3.write(io, acs::ACSet; kwargs...) = JSON3.write(io, generate_json_acset(acs); kwargs...)

so that JSON3.write just works for ACSets. The extra level of indirection is useless for most users who aren't debugging serialization code.

jpfairbanks assigned quffaro

jpfairbanks added enhancement good first issue labels

Contributor

quffaro commented Nov 9, 2023

I've created PR #79 to add this enhancement.

quffaro closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment