added method for JSON3.write specifically for ACSets #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpfairbanks
reviewed
Nov 9, 2023
src/serialization/JSONACSets.jl
Outdated
| @@ -92,7 +92,7 @@ Inverse to [`read_json_acset`](@ref). | |||
| """ | |||
| function write_json_acset(x::ACSet, fname::AbstractString) | |||
| open(fname, "w") do f | |||
| write(f, JSON.json(generate_json_acset(x))) | |||
| write(f, JSON3.json(generate_json_acset(x))) | |||
There was a problem hiding this comment.
this should be
write_json_acset(x::ACSet, fname::AbstractString) = JSON3.write(fname, x)because JSON3 has a method for this now.
jpfairbanks
reviewed
Nov 9, 2023
src/serialization/JSONACSets.jl
Outdated
|
|
||
| Dispatches write to accept ACSets | ||
| """ | ||
| JSON3.write(io::IO, acs::ACSet; kwargs...) = JSON3.write(io, generate_json_acset(acs); kwargs...) |
There was a problem hiding this comment.
move this snippet up to near the other write method on line 93
|
Also remove JSON from Project.toml before merging. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #79 +/- ##
==========================================
+ Coverage 87.55% 87.60% +0.04%
==========================================
Files 22 22
Lines 1840 1839 -1
==========================================
Hits 1611 1611
+ Misses 229 228 -1
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added a method onto
JSON3.writefor writing ACSets. This saves using from composinggenerate_json_acsetintoJSON3.write