Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First class variants in InterTypes #104

Merged
merged 1 commit into from
Jan 24, 2024
Merged

Conversation

olynch
Copy link
Member

@olynch olynch commented Jan 24, 2024

See #85 and #87.

Copy link

codecov bot commented Jan 24, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (3c958fc) 90.89% compared to head (0a6e00a) 90.91%.

Files Patch % Lines
src/intertypes/julia.jl 96.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #104      +/-   ##
==========================================
+ Coverage   90.89%   90.91%   +0.01%     
==========================================
  Files          22       22              
  Lines        2109     2124      +15     
==========================================
+ Hits         1917     1931      +14     
- Misses        192      193       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@jpfairbanks jpfairbanks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jpfairbanks jpfairbanks merged commit f520029 into main Jan 24, 2024
9 checks passed
@epatters epatters deleted the first-class-intertype-variants branch January 24, 2024 22:45
@epatters epatters changed the title First Class Variants First class variants in InterTypes Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants