Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assign type parameters when declaring struct acset type #120

Merged
merged 2 commits into from
Feb 28, 2024
Merged

Assign type parameters when declaring struct acset type #120

merged 2 commits into from
Feb 28, 2024

Conversation

kris-brown
Copy link
Collaborator

Addresses #119

@kris-brown kris-brown self-assigned this Feb 28, 2024
@kris-brown kris-brown added the enhancement New feature or request label Feb 28, 2024
@kris-brown kris-brown linked an issue Feb 28, 2024 that may be closed by this pull request
Bind Julia types to AttrTypes when declaring the ACSet type #119
Closed
@codecov Codecov
Copy link

codecov bot commented Feb 28, 2024 •
edited

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.01%. Comparing base (9244d34) to head (f291f1d).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #120      +/-   ##
==========================================
+ Coverage   91.57%   92.01%   +0.43%     
==========================================
  Files          22       22              
  Lines        1946     1953       +7     
==========================================
+ Hits         1782     1797      +15     
+ Misses        164      156       -8

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

epatters
epatters reviewed Feb 28, 2024
View reviewed changes
Copy link
Member

@epatters epatters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Kris! One question below.

src/DenseACSets.jl Outdated Show resolved Hide resolved
@epatters epatters changed the title assign type parameters at same time as declaring type Assign type parameters when declaring struct acset type Feb 28, 2024
@epatters epatters merged commit 0fed281 into main Feb 28, 2024
9 checks passed
@epatters epatters deleted the type_sugar branch February 28, 2024 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@epatters epatters epatters approved these changes

Assignees

@kris-brown kris-brown

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bind Julia types to AttrTypes when declaring the ACSet type
2 participants
@kris-brown @epatters