Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove stale method for subpart #130

Merged
merged 1 commit into from
Apr 11, 2024
Merged

Remove stale method for subpart #130

merged 1 commit into from
Apr 11, 2024

Conversation

epatters
Copy link
Member

@epatters epatters commented Apr 10, 2024

Not only is this method apparently not being used, its behavior is incompatible with the new intended behavior in #36.

CC @kris-brown

Copy link

codecov bot commented Apr 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.86%. Comparing base (b32967f) to head (14c5639).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #130      +/-   ##
==========================================
+ Coverage   91.81%   91.86%   +0.04%     
==========================================
  Files          23       23              
  Lines        2090     2089       -1     
==========================================
  Hits         1919     1919              
+ Misses        171      170       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@epatters epatters merged commit a3f9f7c into main Apr 11, 2024
9 checks passed
@epatters epatters deleted the unused_subpart_method branch April 11, 2024 04:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant