Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed InterTypes write for Vector{T} to prevent erroring on empty vectors #94

Merged
merged 1 commit into from
Dec 19, 2023

Conversation

p-stokes
Copy link
Contributor

Resolves #93

@p-stokes p-stokes added the bug Something isn't working label Dec 12, 2023
Copy link

codecov bot commented Dec 12, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (813a4e1) 90.57% compared to head (a39c205) 90.43%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #94      +/-   ##
==========================================
- Coverage   90.57%   90.43%   -0.15%     
==========================================
  Files          22       22              
  Lines        2059     2059              
==========================================
- Hits         1865     1862       -3     
- Misses        194      197       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@p-stokes p-stokes requested a review from olynch December 13, 2023 13:50
@olynch olynch merged commit 0b5c038 into main Dec 19, 2023
9 checks passed
@epatters epatters deleted the pas/json_empty_vect branch December 19, 2023 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

jsonwrite of InterTypes errors when writing empty vectors
3 participants