Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optional and Object for InterTypes #96
Optional and Object for InterTypes #96
Changes from all commits
c0b0506
8e20b7f
ab9e6c4
7a761b5
73a25e5
261663d
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 99 in src/intertypes/json.jl
src/intertypes/json.jl#L99
Check warning on line 114 in src/intertypes/json.jl
src/intertypes/json.jl#L114
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The schema of a type can be a list including the string null? Is this a JSONSchema idiom?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think so? This is what showed up on the jsonschema website when I poked around for it, but I'm no jsonschema expert.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fivegrant can probably confirm that it is what he would expect for a nullable field.