Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forgotten Exponential? #33

Closed
olynch opened this issue Jan 16, 2021 · 4 comments
Closed

Forgotten Exponential? #33

olynch opened this issue Jan 16, 2021 · 4 comments

Comments

@olynch
Copy link
Member

olynch commented Jan 16, 2021

I feel like there should be an exp here, am I missing something?

du[sname(pn, j)] = sum(log_rates[i] * dt[i,j] for i in 1:nt(pn))

Ah, the real problem is that they should no longer be called log_rates.

@jpfairbanks
Copy link
Member

Yeah, we tried to solve in log-space for stability, but ran into problems and reversed course. Any input on making this code more stable would be well received.

@olynch
Copy link
Member Author

olynch commented Jan 16, 2021

This wouldn't necessarily make this more stable, but would we get a speedup if we code-genned this, to remove all allocations and loops?

@jpfairbanks
Copy link
Member

That would be useful as an additional functionality. If you have one big Petri net with many parameters, you want to compile it. If you are doing model selection over many small nets, you want to interpret them.

@mehalter
Copy link
Member

Resolved with #107

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants