Fix bad assumption in oapply_typed
#158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epatters
force-pushed
the
fix-oapply-typed
branch
from
048b452
to
e341157
Compare
|
@mehalter, what do you think about the breaking aspect of this PR? To avoid a breaking change, we could modify the outer ports of the supplied UWD if they do not satisfy the required conditions (currently, it throws an errors). This would be slightly inelegant but not too bad. |
|
@epatters thanks for looking into this! Yeah I agree it's a bit unfortunate for this to be a breaking change. I think for now it's a good idea to put in something slightly inelegant to avoid breaking things with a |
|
OK, fixed! This should be ready to go now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #155. Note that the fix requires exposing the junctions in the UWD through outer ports, hence is also a breaking change. See the changes to the unit tests.