Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Incremental hom search to work for patterns with AttrVars #43

Merged
merged 9 commits into from
Feb 28, 2024

Conversation

kris-brown
Copy link
Collaborator

Some changes to Incremental hom search were needed in order to make the process work with ACSets with concrete values as well as variables.

This depends on a modification to Catlab which allows for subobject enumeration of ACSets with variables: AlgebraicJulia/Catlab.jl#887

Copy link

codecov bot commented Feb 26, 2024

Codecov Report

Attention: Patch coverage is 98.73418% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 85.98%. Comparing base (1ef331a) to head (1a7bd6c).

Files Patch % Lines
src/incremental/Incremental.jl 98.71% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #43      +/-   ##
==========================================
+ Coverage   85.30%   85.98%   +0.67%     
==========================================
  Files          31       31              
  Lines        1926     2019      +93     
==========================================
+ Hits         1643     1736      +93     
  Misses        283      283              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kris-brown kris-brown merged commit a5c9950 into main Feb 28, 2024
9 checks passed
@kris-brown kris-brown deleted the attr_incremental branch February 28, 2024 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant