Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Names of FinOrdFunctionLazy and FinOrdFunctionMap #184

Closed
jpfairbanks opened this issue Jul 1, 2020 · 1 comment · Fixed by #197
Closed

Names of FinOrdFunctionLazy and FinOrdFunctionMap #184

jpfairbanks opened this issue Jul 1, 2020 · 1 comment · Fixed by #197
Assignees
Labels

Comments

@jpfairbanks
Copy link
Member

I'm having a hard time remembering these names and I think that the problem is that Lazy and Map aren't semantically related. I think we should use FinOrdFunc and FinOrdVec which are both subtypes of FinOrdFunction or we should use FinOrdLazy and FinOrdEager. Func vs Vec tells you about the storage mechanism and Lazy vs Eager tells you about the evaluation strategy. I'm ok encoding either one, but I think we should be consistent. What do you think?

@epatters
Copy link
Member

epatters commented Jul 1, 2020

I agree, the names are long and cumbersome. I'd prefer FinOrdFunc and FinOrdVec.

For consistency, similar changes should be made for the category FinOrdRel, implemented here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants