Use standard names for FinSet and FinRel #217
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #215 and follows up #184/#197. In summary:
FinOrd
andFinOrdFunction
are renamed toFinSet
andFinFunction
FinOrdRelOb
andFinOrdRelation
are renamed toFinRel
andFinRelation
FinFunction
has concrete subtypesFinFunctionCallable
andFinFunctionVector
andFinRelation
has subtypesFinRelationCallable
andFinRelationMatrix
. The concrete types are exported but should rarely be needed in user code, which can use the constructors forFinFunction
andFinRelation
FinSet{Int}
is the skeleton of FinSet andFinSet{<:AbstractSet}
is FinSet. Currently, only the former is implemented but the latter could be straightforwardly implemented along these lines.I really hope this is the last time we need to rewrite this interface, so if you have concerns, speak now or forever hold your peace :)