Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Composite morphisms and attributes in C-set accessors #298

Merged
merged 4 commits into from
Oct 19, 2020

Conversation

epatters
Copy link
Member

Resolves #294. See the unit tests for examples.

Copy link
Member

@jpfairbanks jpfairbanks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! For the incident(acs, part, [:f, :g]) implementation, we should add a note about the order of composition being incident(acs, incident(acs, part, :f), :g) which is like inv(f) \cdot inv(g) which people might expect to be backwards. I wasn't sure about the order because chaining incident is less intuitive than chaining subpart.

@epatters
Copy link
Member Author

I went back and forth on the order for incident but ultimately decided that the least confusing thing was to make the order [:f,:g] consistent with compose(f,g). I'll add a note to the docs about this.

@epatters epatters merged commit ee276bc into AlgebraicJulia:master Oct 19, 2020
@epatters epatters deleted the cset-access-composition branch October 19, 2020 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using composition in the indexing category for querying C-Set
2 participants