Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistent inferface for serialization and deserialization #41

Closed
epatters opened this issue Aug 26, 2019 · 0 comments
Closed

Consistent inferface for serialization and deserialization #41

epatters opened this issue Aug 26, 2019 · 0 comments
Labels

Comments

@epatters
Copy link
Member

epatters commented Aug 26, 2019

Currently, we use functions like read_graphml both to read from files and to read from a Julia object (XMLDocument), and similarly for write_graphml. This leaves no place for reading from a string.

I like how NetworkX handles this. Use read_ for reading from a file and parse_ for reading from a string or other object, and similarly for write_ and generate_. Adopt this convention across the project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant