Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUILD: Fix error in github actions interpreting | #434

Merged
merged 2 commits into from Jun 8, 2021
Merged

Conversation

mehalter
Copy link
Member

@mehalter mehalter commented Jun 8, 2021

The yml before this PR is completely valid. I think there is a bug in the Github Actions interpreter where it is getting confused. Hoping that this will fix things.

Signed-off-by: Micah Halter <micah@balena.io>
@mehalter mehalter added the bug label Jun 8, 2021
@mehalter mehalter self-assigned this Jun 8, 2021
@mehalter mehalter requested a review from epatters June 8, 2021 15:10
Signed-off-by: Micah Halter <micah@balena.io>
@mehalter mehalter requested review from epatters and removed request for epatters June 8, 2021 15:14
@github-actions
Copy link
Contributor

github-actions bot commented Jun 8, 2021

Review Checklist

Does this PR follow the development guidelines? Following is a partial checklist:

Tests

  • New features and bug fixes have unit tests
  • New modules have tests that are ultimately called by the test runner (test/runtests.jl)
  • Existing tests have not been deleted
  • Code coverage >= 90% or reduction justified in PR

Documentation

  • All exported functions, types, and constants have docstrings, written in complete sentences
  • Citations are given for any constructions, algorithms, or code drawn from external sources

Other

  • Style guidelines are followed, including indent width 2
  • Changes breaking backwards compatibility have been approved

@mehalter
Copy link
Member Author

mehalter commented Jun 8, 2021

Ay! Check out that fancy list^

Also we can ignore the one failed "Review Chacklist". That was a failed run before the most recent commit

Copy link
Member

@epatters epatters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fixes, Micah! It's too bad that GitHub's YAML parser doesn't work on valid YAML.

@mehalter mehalter merged commit 110c55a into master Jun 8, 2021
@mehalter mehalter deleted the checklist branch June 8, 2021 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants