Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUILD: Fix error in github actions interpreting | #434

Merged
merged 2 commits into from Jun 8, 2021
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
43 changes: 21 additions & 22 deletions .github/workflows/reviewchecklist.yml
@@ -1,7 +1,7 @@
name: Review Checklist

on:
pull_request_target:
pull_request:
types: [review_requested]

jobs:
Expand All @@ -14,24 +14,23 @@ jobs:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
with:
check_for_duplicate_msg: true
msg: |-
### Review Checklist

Does this PR follow the [development guidelines](https://github.com/AlgebraicJulia/Catlab.jl/wiki/Guidelines-for-PR-writers-and-reviewers)? Following is a *partial* checklist:

**Tests**

- [ ] New features and bug fixes have unit tests
- [ ] New modules have tests that are ultimately called by the test runner (`test/runtests.jl`)
- [ ] Existing tests have not been deleted
- [ ] Code coverage >= 90% or reduction justified in PR

**Documentation**

- [ ] All exported functions, types, and constants have docstrings, written in complete sentences
- [ ] Citations are given for any constructions, algorithms, or code drawn from external sources

**Other**

- [ ] Style guidelines are followed, including indent width 2
- [ ] Changes breaking backwards compatibility have been approved
msg: "### Review Checklist\n
\n
Does this PR follow the [development guidelines](https://github.com/AlgebraicJulia/Catlab.jl/wiki/Guidelines-for-PR-writers-and-reviewers)? Following is a *partial* checklist:\n
\n
**Tests**\n
\n
- [ ] New features and bug fixes have unit tests\n
- [ ] New modules have tests that are ultimately called by the test runner (`test/runtests.jl`)\n
- [ ] Existing tests have not been deleted\n
- [ ] Code coverage >= 90% or reduction justified in PR\n
\n
**Documentation**\n
\n
- [ ] All exported functions, types, and constants have docstrings, written in complete sentences\n
- [ ] Citations are given for any constructions, algorithms, or code drawn from external sources\n
\n
**Other**\n
\n
- [ ] Style guidelines are followed, including indent width 2\n
- [ ] Changes breaking backwards compatibility have been approved"