New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Roll back added C-set parts on error #305

Merged

epatters merged 2 commits into AlgebraicJulia:master from epatters:cset-add-parts-error-handling

Oct 23, 2020

Member

epatters commented Oct 21, 2020 •

edited

Loading

With #293 implemented, we can finally resolve #199 in a satisfactory way. The previous fix was in #204.


          CLEANUP: Roll back added C-set parts when setting subparts fails.

880b930

epatters added the cleanup label


          TST: Adding edges to graph rolled back when source/target don't exist.

958f557

epatters requested a review from jpfairbanks

October 21, 2020 21:24

jpfairbanks approved these changes

View reviewed changes

epatters merged commit 41ce445 into AlgebraicJulia:master

epatters deleted the cset-add-parts-error-handling branch

October 23, 2020 17:01

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment