Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

@acset macro fix for runtime values #463

Merged
merged 1 commit into from
Jul 14, 2021
Merged

@acset macro fix for runtime values #463

merged 1 commit into from
Jul 14, 2021

Conversation

olynch
Copy link
Contributor

@olynch olynch commented Jul 12, 2021

Addresses #455

epatters
epatters requested changes Jul 13, 2021
View reviewed changes
Copy link
Member

@epatters epatters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Owen, this looks good, but the tests are still failing. Also it looks like an indent width of 4 has crept into a few places.

epatters
epatters approved these changes Jul 14, 2021
View reviewed changes
Copy link
Member

@epatters epatters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@epatters epatters merged commit aa8032c into AlgebraicJulia:master Jul 14, 2021
@epatters epatters mentioned this pull request Jul 30, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@epatters epatters epatters approved these changes

Assignees
No one assigned
Labels
cleanup
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@olynch @epatters