Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partiality in ACSets handled in a well-defined and well-understood way #681

Merged
merged 1 commit into from
Oct 6, 2022

Conversation

olynch
Copy link
Contributor

@olynch olynch commented Sep 27, 2022

Currently, the story for partiality in ACSets is that we assume it doesn't exist, except for when it's convenient in building them.

There are also some subtle bugs, some of which we know exist (like int-valued attributes defaulting to zero) and some of which we are only fearful of (???) due to the janky way we currently handle partiality.

For this PR, we should have:

  • A thorough control and understanding over where partiality will throw errors, where partiality will return default values, and where partiality will return "none" types.
  • A coherent story for partial ACSets, where variables for attributes might be introduced
  • A coherent story for ACSet transformations that could be partial.

As part of this work, acsets also have been migrated into a separate folder, and no longer depend on presentations.

@olynch olynch changed the title The next acset refactor Partiality in ACSets handled in a well-defined and well-understood way Sep 27, 2022
@olynch olynch marked this pull request as ready for review October 4, 2022 23:46
Copy link
Member

@epatters epatters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another clean and elegant refactor of the acsets machinery! This will open the door to all sorts of acset extensions, such as sparse or distributed acsets.

docs/src/index.md Show resolved Hide resolved
src/acsets/Columns.jl Outdated Show resolved Hide resolved
src/acsets/Columns.jl Outdated Show resolved Hide resolved
src/acsets/Columns.jl Outdated Show resolved Hide resolved
src/acsets/Columns.jl Outdated Show resolved Hide resolved
src/acsets/DenseACSets.jl Outdated Show resolved Hide resolved
src/acsets/LVectors.jl Show resolved Hide resolved
src/theories/Schema.jl Show resolved Hide resolved
test/categorical_algebra/CSetDataStructures.jl Outdated Show resolved Hide resolved
test/categorical_algebra/CSets.jl Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants