Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move acset homomorphism search into own submodule #843

Merged
merged 3 commits into from Sep 3, 2023
Merged

Move acset homomorphism search into own submodule #843

merged 3 commits into from Sep 3, 2023

Conversation

kris-brown
Copy link
Contributor

@kris-brown kris-brown commented Aug 30, 2023 •
edited

This PR simply migrates some code from CSets.jl to a new file HomSearch.jl. Addresses #774

(Also a minor cleanup of replacing out_homs(S,c) and in_homs(S,c) with homs(S; to=c) and homs(S; from=c).)

@kris-brown kris-brown self-assigned this Aug 30, 2023
epatters
epatters requested changes Sep 1, 2023
View reviewed changes
Copy link
Member

@epatters epatters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Kris! This looks good apart from one small comment.

src/categorical_algebra/HomSearch.jl Outdated Show resolved Hide resolved
@epatters epatters changed the title Separate CSet search problems (e.g. HomSearch) into separate file Move acset homomorphism search into own submodule Sep 1, 2023
@epatters epatters added the acsets label Sep 1, 2023
@AlgebraicJulia AlgebraicJulia deleted a comment from github-actions bot Sep 1, 2023
epatters
epatters requested changes Sep 2, 2023
View reviewed changes
Copy link
Member

@epatters epatters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I didn't notice this the first time, but shouldn't we also reorganize the tests accordingly?

@kris-brown
Copy link
Contributor Author

kris-brown commented Sep 2, 2023 •
edited

Good point! There are still some calls to homomorphism in CSets.jl but the dedicated hom search and subobject search tests are now moved

epatters
epatters approved these changes Sep 3, 2023
View reviewed changes
Copy link
Member

@epatters epatters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Kris!

@epatters epatters merged commit 05cfe2a into AlgebraicJulia:main Sep 3, 2023
13 checks passed
@kris-brown kris-brown deleted the split_homsearch branch September 5, 2023 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@epatters epatters epatters approved these changes

Assignees

@kris-brown kris-brown

Labels
acsets cleanup infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kris-brown @epatters