Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Sheaf implementation #852

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add Sheaf implementation #852

wants to merge 3 commits into from

Conversation

jpfairbanks
Copy link
Member

This PR adds a module for sheaves, including abstract types. It has an example for free vector space as a sheaf over Diag(FinSet).

@github-actions
Copy link
Contributor

Review Checklist

Does this PR follow the development guidelines? Following is a partial checklist:

Tests

  • New features and bug fixes have unit tests
  • New modules have tests that are ultimately called by the test runner (test/runtests.jl)
  • Existing tests have not been deleted
  • Code coverage >= 90% or reduction justified in PR

Documentation

  • All exported functions, types, and constants have docstrings, written in complete sentences
  • Citations are given for any constructions, algorithms, or code drawn from external sources

Other

  • Style guidelines are followed, including indent width 2
  • Changes breaking backwards compatibility have been approved

@jpfairbanks
remove spurious whitespace change
35d94c8 
There was a merge conflict with main due to this line.
Removing it should remove the conflict.
@jpfairbanks jpfairbanks self-assigned this Apr 29, 2024
@jpfairbanks
Copy link
Member Author

@tylerhanks, can you review this? I want to add an example for induced subgraphs next.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjaminmerlinbumpus benjaminmerlinbumpus benjaminmerlinbumpus approved these changes

@tylerhanks tylerhanks Awaiting requested review from tylerhanks

Assignees

@jpfairbanks jpfairbanks

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jpfairbanks @benjaminmerlinbumpus