Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redesign ACSetFunctors when there are AttrVars #915

Merged
merged 3 commits into from
Jun 21, 2024

Conversation

KevinDCarlson
Copy link
Contributor

Modifications to make attrvars play nicer with data migrations. The key change in CSets is to redefine ACSetFunctors, which are used critically in data migrations to compose with ordinary functors representing the migrations themselves, to again always take values in FinSetInts and FinDomFunctions when possible. Previously, the ACSetFunctor of an ACSet containing any Attrvars would take values entirely in VarSets, which both confused the difference between actual Attrvars and combinatorial data and interfaced badly with the Limits API.

To make this work I also defined how to compose FinFunctions with VarFunctions on the left.

@AlgebraicJulia AlgebraicJulia deleted a comment from github-actions bot Jun 21, 2024
@epatters epatters changed the title Redesign ACSetFunctors when there are Attrvars Redesign ACSetFunctors when there are AttrVars Jun 21, 2024
Copy link
Member

@epatters epatters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Kevin! This change makes good sense to me.

I'll merge once the conflict is fixed.

@KevinDCarlson
Copy link
Contributor Author

Hm, dunno what that was about but I've fixed it.

@epatters epatters merged commit c1dc167 into main Jun 21, 2024
10 checks passed
@epatters epatters deleted the improveVaracsetToFinfunctor branch June 21, 2024 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants