Set orientations when making dual simplices #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems like a bit of a foot gun to default to invalid orientations instead of raising an exception. Let's get the build working with this approach, but open an issue about how to handle it in general with @epatters. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using recent versions of Catlab, the MeshInterop tests are failing due to edge orientations being set to
nothinginstead of a default value, as was the previous behavior.This pull request solves this issue by calling
orient!inside themake_dual_simplicesfunctions if orientations are not set. If a valid orientation is not found, then arbitrary orientations are set.Currently, all
CombinatorialSpaces.jltests pass, as well as relevant tests inDecapodes.jlthat depend on this package.