Support 3D Simplicial Sets #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukem12345
commented
Jun 16, 2023
lukem12345
commented
Jun 16, 2023
lukem12345
commented
Jun 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to track progress on implementing 3D (semi-)simplicial sets in SimplicialSets.jl.
Currently, CombinatorialSpaces.jl supports only 1D and 2D simplicial sets. Although some methods are implemented for arbitrary dimension, such as
orient!, these methods cannot take advantage of this flexibility due to the lack of higher dimensional simplicial complexes stored as ACSets.Although there may be some benefits to refactoring SimplicialSets.jl to support arbitrary ND, the diminishing utility for dimensions beyond 3 or 4 for physical applications justifies focusing on a hand-written implementation of 3D simplicial sets for the time being. This is not to say that there is no utility to such an approach. One advantage is that of long-term maintainability at the expense of a larger up-front engineering effort.