Short-term fix for wire hovering bug #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There are a few other minor changes:
|
olynch
approved these changes
Jun 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is currently a bug (#117) where wires in DWD are not hoverable/clickable after they are drawn.
I've tracked it down to the removal of the
Interactableattribute at the end of the drag, which doesn't trigger an update. As a short-term fix, I am setting the value totrueat the end of the drag instead, but this is just a short-term fix, as attribute removal should be triggering the update.The problem isn't showing up in
simplepetri, which calls the samedragEdgemethod, but without the bells and whistles (port lifting, type propagation).