Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor for embedding support #141

Closed
wants to merge 18 commits into from
Closed

Refactor for embedding support #141

wants to merge 18 commits into from

Conversation

olynch
Copy link
Collaborator

@olynch olynch commented Jun 21, 2023

No description provided.

@netlify
Copy link

netlify bot commented Jun 21, 2023

Deploy Preview for semagrams failed.

Name Link
🔨 Latest commit fbedd77
🔍 Latest deploy log https://app.netlify.com/sites/semagrams/deploys/64d6df4ffb11240008bbaebb

@olynch
Copy link
Collaborator Author

olynch commented Jun 24, 2023

Some thoughts on the direction that this is going.

  1. We need a trial application that we embed Semagrams in for me to figure out what the API should be, or how things would work at all.
  2. Now that a Semagram is more directly just the display of the actual ACSet, I think it makes sense to eliminate the Entity/Part distinction, @sjbreiner should be happy about that. What used to be the UI viewport is now just going to be handled outside of the Semagram, in a way that doesn't have to conform to the Semagrams paradigm.
  3. The way that I'm redesigning bindings by splitting up the "hook" and the "action", it should be easier to automatically generate a help message.

@olynch
Copy link
Collaborator Author

olynch commented Jun 24, 2023

Most actions should only need the stuff in here:

case class Resources(
. Does it make sense to have this class?

We have a trait that we extend in order to make the display. Should we also have a trait that we extend in order to make the control process? How does the control process interact with the rest of the app?

@olynch olynch added enhancement New feature or request UI labels Aug 10, 2023
@olynch
Copy link
Collaborator Author

olynch commented Oct 20, 2023

replaced by dev

@olynch olynch closed this Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants