Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

searching_in_sorted_rotated_array.cpp #361

Merged
merged 14 commits into from Apr 26, 2021
Merged

searching_in_sorted_rotated_array.cpp #361

merged 14 commits into from Apr 26, 2021

Conversation

rohitsigar
Copy link
Contributor

File content -

  1. optimal code in c++
  2. valuable comments
  3. Time complexity and Space Complexity Analysis
  4. Test Cases with explanation
  5. Complete explanation

@rohitsigar
Copy link
Contributor Author

@plazzy99 @nakul-19 please check my PR for the issue assigned to me #51

@rohitsigar
Copy link
Contributor Author

@plazzy99 @nakul-19 please check my PR there was an issue in the java code which I have resolved now

@rohitsigar rohitsigar mentioned this pull request Mar 10, 2021
Closed
vatsalkesarwani12
vatsalkesarwani12 requested changes Mar 10, 2021
View reviewed changes
Copy link
Member

@vatsalkesarwani12 vatsalkesarwani12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update the readme for both the code

Code/C++/searching_in_sorted_rotated_array.cpp Outdated Show resolved Hide resolved
Code/Java/searching_in_sorted_rotated_array.java Outdated Show resolved Hide resolved
@vatsalkesarwani12
Copy link
Member

One important thing you have to raise another pr with java code and its readme. and update this pr with only cpp code

As we accept only 1 pr with 1 language linked with 1 issue

@rohitsigar
Copy link
Contributor Author

@plazzy99 please can you tell me what do I have to update in the readme file?

@rohitsigar rohitsigar closed this Mar 10, 2021
@rohitsigar rohitsigar reopened this Mar 10, 2021
@rohitsigar
Copy link
Contributor Author

@plazzy99 I have shifted the Position of Test cases in the C++ file and once this PR is done I will do the same for the java file

vatsalkesarwani12
vatsalkesarwani12 requested changes Mar 16, 2021
View reviewed changes
.vscode/extensions.json Outdated
@@ -0,0 +1,13 @@
{
// See https://go.microsoft.com/fwlink/?LinkId=827846 to learn about workspace recommendations.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

delete this file

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have removed .vscode/extensions.json !!

@sg-iitg sg-iitg mentioned this pull request Mar 26, 2021
Merged
tarun26091999
tarun26091999 requested changes Apr 6, 2021
View reviewed changes
Copy link
Member

@tarun26091999 tarun26091999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

link it to the folder.

@rohitsigar
Copy link
Contributor Author

I have updated the readme file please review it.

tarun26091999
tarun26091999 requested changes Apr 18, 2021
View reviewed changes
Copy link
Member

@tarun26091999 tarun26091999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove the cpp code

@rohitsigar
Copy link
Contributor Author

I have removed the CPP file.

@yasharth291 yasharth291 merged commit 9fd830d into Algo-Phantoms:main Apr 26, 2021
@yasharth291 yasharth291 added gssoc21 Girlscript summer of code 2021 Level1 medium labels Apr 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vatsalkesarwani12 vatsalkesarwani12 Awaiting requested review from vatsalkesarwani12

@tarun26091999 tarun26091999 Awaiting requested review from tarun26091999

Assignees
No one assigned
Labels
gssoc21 Girlscript summer of code 2021 Level1 medium
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@rohitsigar @vatsalkesarwani12 @tarun26091999 @yasharth291