Fix trait annotations, add missed methods

Algo-Web · May 24, 2020 · 6b69b4d · 6b69b4d
1 parent fe515b1
commit 6b69b4d
Show file tree

Hide file tree

Showing 5 changed files with 15 additions and 6 deletions.
diff --git a/src/MetadataV3/Edm/EntityContainer/EntitySet.php b/src/MetadataV3/Edm/EntityContainer/EntitySet.php
@@ -41,7 +41,7 @@
  */
 class EntitySet extends EdmBase
 {
-    use HasDocumentation, HasAnnotations, HasValueAnnotation;
+    use HasDocumentation, HasAnnotations;
     /**
      * @var string $name
      */

diff --git a/src/MetadataV3/Edm/ModelFunctionParameter.php b/src/MetadataV3/Edm/ModelFunctionParameter.php
@@ -51,7 +51,7 @@
  */
 class ModelFunctionParameter extends EdmBase
 {
-    use HasType, HasCollation, HasValueAnnotation;
+    use HasType, HasValueAnnotation;
     /**
      * @var string $name
      */

diff --git a/src/MetadataV3/Edm/OtherTypeConstructs/CollectionType.php b/src/MetadataV3/Edm/OtherTypeConstructs/CollectionType.php
@@ -116,4 +116,9 @@ public function getChildElements(): array
         }
         return [];
     }
+
+    public function isAttribute(): bool
+    {
+       return false;
+    }
 }
diff --git a/src/MetadataV3/Edm/OtherTypeConstructs/RowType.php b/src/MetadataV3/Edm/OtherTypeConstructs/RowType.php
@@ -110,4 +110,9 @@ public function getChildElements(): array
     {
         return $this->propertyTypes;
     }
+
+    public function isAttribute(): bool
+    {
+        return false;
+    }
 }
diff --git a/src/MetadataV3/Edm/Property.php b/src/MetadataV3/Edm/Property.php
@@ -76,17 +76,16 @@ class Property extends EdmBase
 {
     use HasValueAnnotation,
         HasCommonPropertyAttributes,
-        HasDocumentation,
-        HasAccessors;
+        HasDocumentation;
+
     public function __construct(
         string $name,
         string $type,
         bool $nullable = null,
         string $defaultValue = null,
         int $maxLength = null,
         int $fixedLength = null,
-        int
-        $precision = null,
+        int $precision = null,
         int $scale = null,
         bool $unicode = true,
         EDMSimpleType $collection = null,