Rig MetadataTrait tests to indicate access violations

Algo-Web · Sep 20, 2017 · af0d2fd · af0d2fd
1 parent 4381fdd
commit af0d2fd
Showing 1 changed file with 9 additions and 3 deletions.
diff --git a/tests/unit/Models/MetadataTraitTest.php b/tests/unit/Models/MetadataTraitTest.php
@@ -33,6 +33,15 @@ public function setUp()
     {
         parent::setUp();
         $this->object = $this->getMockForTrait('\AlgoWeb\PODataLaravel\Models\MetadataTrait');
+        $msg = 'Simple metadata provider cannot be called from metadata trait';
+        $meta = m::mock(SimpleMetadataProvider::class);
+        $meta->shouldReceive('resolveResourceProperty')->andThrow(new \Exception($msg))->never();
+        $meta->shouldReceive('addEntityType')->andThrow(new \Exception($msg))->never();
+        $meta->shouldReceive('addKeyProperty')->andThrow(new \Exception($msg))->never();
+        $meta->shouldReceive('addPrimitiveProperty')->andThrow(new \Exception($msg))->never();
+        $meta->shouldReceive('addResourceReferenceProperty')->andThrow(new \Exception($msg))->never();
+        $meta->shouldReceive('addResourceSetReferenceProperty')->andThrow(new \Exception($msg))->never();
+        App::instance('metadata', $meta);
     }
 
     /**
@@ -411,7 +420,6 @@ public function testHookUpRelationshipsHasOnlyHasOneRelations()
         $meta = m::mock(SimpleMetadataProvider::class);
         $meta->shouldReceive('addResourceReferenceProperty')->withAnyArgs()->andReturnNull()->once();
         $meta->shouldReceive('addResourceSetReferenceProperty')->withAnyArgs()->andReturnNull()->never();
-        App::instance('metadata', $meta);
 
         $foo = m::mock(TestModel::class)->makePartial()->shouldAllowMockingProtectedMethods();
         $fooName = get_class($foo);
@@ -439,7 +447,6 @@ public function testHookUpRelationshipsHasOnlyHasManyRelations()
         $meta = m::mock(SimpleMetadataProvider::class);
         $meta->shouldReceive('addResourceReferenceProperty')->withAnyArgs()->andReturnNull()->never();
         $meta->shouldReceive('addResourceSetReferenceProperty')->withAnyArgs()->andReturnNull()->once();
-        App::instance('metadata', $meta);
 
         $foo = m::mock(TestModel::class)->makePartial()->shouldAllowMockingProtectedMethods();
         $fooName = get_class($foo);
@@ -640,7 +647,6 @@ public function testGetXmlSchemaOnUnknownSideOfPolymorphic()
         $metaProv->shouldReceive('resolveResourceType')->andReturn($entity)->never();
         $metaProv->shouldReceive('addEntityType')->andReturn($base);
 
-        App::instance('metadata', $metaProv);
 
         //$foo = new TestMorphOneSource($meta);
         $foo = m::mock(TestMorphOneSource::class)->makePartial();