Add ability to pass children to Icon #123

dusty · 2018-11-03T22:30:30Z

I use bloomer and also the react fontawesome library.

I was using an older version of bloomer that accepted children for the Icon component. I noticed that it was changed in a previous commit and was hoping it could be added back. Let me know what you think.

Thanks for this fantastic library. :)

Here is an example of how I use it.

<Icon isAlign="left">
  <FontAwesomeIcon icon={faEnvelope} />
</Icon>

coveralls · 2018-11-03T22:33:26Z

Coverage remained the same at 100.0% when pulling f9ec190 on dusty:master into b9af827 on AlgusDark:master.

ptitmouton · 2019-03-23T17:35:10Z

src/elements/Icon.tsx

@@ -30,7 +30,7 @@ export function Icon({children, ...props }: Icon<HTMLElement>) {

    const icon = (
        <span {...HTMLProps} className={className}>
-            <i className={`${props.className}`} aria-hidden="true"></i>
+            {children ? children : (<i className={`${props.className}`} aria-hidden="true"></i>)}


I'd really like this PR to get merged. What is the state of this?
Is there anyone to approve?

I think the solution is a good one.

Maybe this would be slightier more readable?

Suggested change

{children ? children : (<i className={`${props.className}`} aria-hidden="true"></i>)}

{children || <i className={`${props.className}`} aria-hidden="true" />}

It would fix #126

Add ability to pass children to Icon

f9ec190

ptitmouton reviewed Mar 23, 2019

View reviewed changes

dusty closed this Mar 24, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add ability to pass children to Icon #123

Add ability to pass children to Icon #123

dusty commented Nov 3, 2018

coveralls commented Nov 3, 2018

ptitmouton Mar 23, 2019

	{children ? children : (<i className={`${props.className}`} aria-hidden="true"></i>)}
	{children \|\| <i className={`${props.className}`} aria-hidden="true" />}

Add ability to pass children to Icon #123

Add ability to pass children to Icon #123

Conversation

dusty commented Nov 3, 2018

coveralls commented Nov 3, 2018

ptitmouton Mar 23, 2019

Choose a reason for hiding this comment