This repository has been archived by the owner on Feb 13, 2023. It is now read-only.
Migrated to React 16.2.0 #87
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upgraded some additional dependencies and configured jest tests
Closed
|
Just seen the Travis issue. Unfortunately I am unable to reproduce the error on my local system. |
Fixing HTMLDialog Element TypeScipt Error
using --runInBand
|
Okay I was able to detect with issue. Came from using jest v3 without additional travis configuration. |
Merged
AlgusDark
reviewed
Feb 23, 2018
|
Already did and no problem occured. But maybe thats dependent on my local system. I will try to validate that later today. |
|
I found issues relating to Typescript. I will close this for good and just give you the advice to use runInBand flag. |
|
So is the only reason this didn't get merged is because of Travis? Can this PR be used as a base for a React 16 version of bloomer or is it completely incompatible? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgraded some additional dependencies and configured jest tests
Relative Issue #80