Upgrade to AndroidX #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AliAsadi
reviewed
Jan 9, 2023
Used the automated conversion in Android Studio. We need to move to a newer version of Expandable Recyclerview which will happen in the next commit.
The original library is abandoned, someone else already updated it but added their own stuff. I've only kept the AndroidX upgrade releated changes from them. I then updated Gradle to the latest in the version order that Android Studio updated in. New Upstream Fork: https://github.com/AliAsadi/expandable-recycler-view Original Fork: https://github.com/deadman96385/expandable-recycler-view
Removed the applicationid from the manifest and converted the library and sample app to use Namespace as needed by newer gradle. Application id is recommended to match namespace. Which you can see below: https://developer.android.com/studio/build/configure-app-module#set-namespace:~:text=application%20ID.-,Change%20the%20namespace,-In%20most%20cases Update gradle-wrapper.properties
deadman96385
force-pushed
the
master
branch
2 times, most recently
from
298b66c
to
5f55f78
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #30
I used the automated converter, which worked overall other then I had to also get an updated copy of Expandable Recycler. This was needed because AndroidX changes the Recyclerview some and so the support library you use needed updates. I've tested this against both the your sample app as well as the expandable recyclerview sample app. I haven't noticed any breakages.
https://github.com/deadman96385/expandable-recycler-view/commits/master