Updated code to newer android compatibles, Updated error 9-patch #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks a lot, @OmarShoaib for contributing to this library and your support in giving back to the community. Shoaib, it has been quite some time that I wasn't maintaining this library due to that you people are facing issues. |
|
For your reference. |
|
@OmarShoaib I got it and thanks a lot for pointing out this issue. Can you please remove .idea files from your PR so, I can merge it? |
|
I am going this PR and will generate the release in a while |
AliAzaz
approved these changes
Oct 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Ali,
First of all, this repository of yours is literally amazing and helpful. While using this library I encountered an issue in which error image you used messes up the UI as the field gets bigger because of this image on error prompt. So I've updated that image plus upgraded your project to run on newer android versions.
It'll be really grateful to you if you could accept this pull request.
Please let me know if you want to ask anything. I'm just a message away.
Thanks.