Update #1
Merged
Update #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Alexander Graf <ghostwheel42@users.noreply.github.com>
Co-authored-by: Alexander Graf <ghostwheel42@users.noreply.github.com>
Co-authored-by: Alexander Graf <ghostwheel42@users.noreply.github.com>
Co-authored-by: Alexander Graf <ghostwheel42@users.noreply.github.com>
Co-authored-by: Alexander Graf <ghostwheel42@users.noreply.github.com>
2668: Start unbound with intended arguments r=mergify[bot] a=ScoreUnder Unbound looked like it was meant to be started as if by `unbound -c /etc/unbound/unbound.conf`, but instead the string `-c /etc/unbound/unbound.conf` was set as argv[0] of the unbound command, meaning it is never parsed. ## What type of PR? "Bugfix", but it works anyway without it -- it's just misleading to see a couple of arguments looking like they're being passed but actually just setting the display name of the process instead ## What does this PR do? Calls execv with an argv list of 3 arguments (program name and intended 2 arguments) rather than just a program name. This appeared to be the intent of the original author. ### Related issue(s) ## Prerequisites Before we can consider review and merge, please make sure the following list is done and checked. If an entry in not applicable, you can check it or remove it from the list. - [x] In case of feature or enhancement: documentation updated accordingly (n/a: bug) - [x] Unless it's docs or a minor change: add [changelog](https://mailu.io/master/contributors/workflow.html#changelog) entry file. (n/a: minor) Co-authored-by: score <seejay.11@gmail.com>
2664: Fix the bug reported by fastlorenzo r=mergify[bot] a=nextgens ## What type of PR? bug-fix ## What does this PR do? Fix the bug reported by fastlorenzo: when using proxy-auth, if the user doesn't exist you have to hit the URL twice. ### Related issue(s) ## Prerequisites Before we can consider review and merge, please make sure the following list is done and checked. If an entry in not applicable, you can check it or remove it from the list. - [ ] In case of feature or enhancement: documentation updated accordingly - [ ] Unless it's docs or a minor change: add [changelog](https://mailu.io/master/contributors/workflow.html#changelog) entry file. Co-authored-by: Florent Daigniere <nextgens@freenetproject.org>
Czech translation
All override files are used as if they were placed in the rspamd local.d folder. From the newsfragment: New override system for Rspamd. In the old system, all files were placed in the Rspamd overrides folder. These overrides would override everything, including the Mailu Rspamd config. Now overrides are placed in /overrides. If you use your own map files, change the location to /override/myMapFile.map in the corresponding conf file. It works as following. * If the override file overrides a Mailu defined config file, it will be included in the Mailu config file with lowest priority. It will merge with existing sections. * If the override file does not override a Mailu defined config file, then the file will be placed in the rspamd local.d folder. It will merge with existing sections. For more information, see the description of the local.d folder on the rspamd website: https://www.rspamd.com/doc/faq.html#what-are-the-locald-and-overrided-directories
2665: Update to docker compose v2 r=mergify[bot] a=nextgens ## What type of PR? documentation ## What does this PR do? Update to docker compose v2 ### Related issue(s) - close #2663 ## Prerequisites Before we can consider review and merge, please make sure the following list is done and checked. If an entry in not applicable, you can check it or remove it from the list. - [x] In case of feature or enhancement: documentation updated accordingly - [ ] Unless it's docs or a minor change: add [changelog](https://mailu.io/master/contributors/workflow.html#changelog) entry file. Co-authored-by: Florent Daigniere <nextgens@freenetproject.org> Co-authored-by: Florent Daigniere <nextgens@users.noreply.github.com>
2660: Fail2ban update r=mergify[bot] a=nextgens ## What type of PR? documentation ## What does this PR do? Change the instructions on how to setup fail2ban ### Related issue(s) ## Prerequisites Before we can consider review and merge, please make sure the following list is done and checked. If an entry in not applicable, you can check it or remove it from the list. - [ ] In case of feature or enhancement: documentation updated accordingly - [x] Unless it's docs or a minor change: add [changelog](https://mailu.io/master/contributors/workflow.html#changelog) entry file. Co-authored-by: Florent Daigniere <nextgens@freenetproject.org>
2835: Note ports that need to be open in the firewall r=mergify[bot] a=strugee ## What type of PR? Documentation ## What does this PR do? The primary purpose of this change is to include the keyword "firwall" because when I went to open up ports in my network security group I expected a search for "firewall" in the docs to instantly bring this information up, but it didn't. ### Related issue(s) :shrug: none that I saw offhand ## Prerequisites Before we can consider review and merge, please make sure the following list is done and checked. If an entry in not applicable, you can check it or remove it from the list. - [x] In case of feature or enhancement: documentation updated accordingly - [x] Unless it's docs or a minor change: add [changelog](https://mailu.io/master/contributors/workflow.html#changelog) entry file. Co-authored-by: AJ Jordan <alex@strugee.net>
… non latin-1 character.
Remove password from response (not needed)
2838: Authentication failed for email clients when the password contained a non latin-1 character. r=mergify[bot] a=Diman0 ## What type of PR? bug fix ## What does this PR do? Fixes a bug that results in authentication failing for email clients when the password contains a non latin-1 character. Issue was caused by the header Auth-Password being returned with non latin-1 characters. Headers must always be latin-1 encoded. Resolved the issue by url encoding the password. Since the returned password is only used as a partial hash for the rate limiter, I did not add code for un-quoting the password in the /internal/email endpoint. ### Related issue(s) - closes #2837 ## Prerequisites Before we can consider review and merge, please make sure the following list is done and checked. If an entry in not applicable, you can check it or remove it from the list. - [x] In case of feature or enhancement: documentation updated accordingly - [x] Unless it's docs or a minor change: add [changelog](https://mailu.io/master/contributors/workflow.html#changelog) entry file. Co-authored-by: Dimitri Huisman <diman@huisman.xyz> Co-authored-by: Florent Daigniere <nextgens@users.noreply.github.com>
2844: Ensure we log which account is invalid r=mergify[bot] a=nextgens ## What type of PR? bug-fix ## What does this PR do? Ensure we log which account is invalid ### Related issue(s) ## Prerequisites Before we can consider review and merge, please make sure the following list is done and checked. If an entry in not applicable, you can check it or remove it from the list. - [ ] In case of feature or enhancement: documentation updated accordingly - [x] Unless it's docs or a minor change: add [changelog](https://mailu.io/master/contributors/workflow.html#changelog) entry file. Co-authored-by: Florent Daigniere <nextgens@freenetproject.org>
2815: Update version to 2.+ in release template r=mergify[bot] a=OdyX ## What type of PR? Documentation ## What does this PR do? It's really weird that releases 2.0+ such as https://github.com/Mailu/Mailu/releases/tag/2.0.12 mention 1.9 and 1.9.1; fixin' this. Co-authored-by: Didier 'OdyX' Raboud <odyx@raksha.ch>
2847: Use dovecot-proxy r=mergify[bot] a=nextgens ## What type of PR? enhancement ## What does this PR do? Use dovecot-proxy instead of nginx's mail module. This will be required if we want to have BURL, XOAUTH2 or HA/load-balancing (with more than one IMAP instance). pros: - fixes $remote_port cons: - seems to break SSL resumption ### Related issue(s) - closes #2848 ## Prerequisites Before we can consider review and merge, please make sure the following list is done and checked. If an entry in not applicable, you can check it or remove it from the list. - [ ] In case of feature or enhancement: documentation updated accordingly - [ ] Unless it's docs or a minor change: add [changelog](https://mailu.io/master/contributors/workflow.html#changelog) entry file. Co-authored-by: Florent Daigniere <nextgens@freenetproject.org>
2869: increase the number of postfix workers r=mergify[bot] a=nextgens ## What type of PR? bug-fix ## What does this PR do? increase the number of postfix workers. It was reduced when we were using postscreen ... but this specific part hasn't been reverted properly. The practical effect is that we should see less ``451 4.3.2 Internal server error``. ### Related issue(s) - #2861 ## Prerequisites Before we can consider review and merge, please make sure the following list is done and checked. If an entry in not applicable, you can check it or remove it from the list. - [ ] In case of feature or enhancement: documentation updated accordingly - [x] Unless it's docs or a minor change: add [changelog](https://mailu.io/master/contributors/workflow.html#changelog) entry file. Co-authored-by: Florent Daigniere <nextgens@freenetproject.org>
2871: Document that the default config for netplan is broken r=mergify[bot] a=nextgens ## What type of PR? documentation ## What does this PR do? Document in the FAQ that what looks like DNSSEC failures may be netplan related. ### Related issue(s) - #2868 ## Prerequisites Before we can consider review and merge, please make sure the following list is done and checked. If an entry in not applicable, you can check it or remove it from the list. - [ ] In case of feature or enhancement: documentation updated accordingly - [ ] Unless it's docs or a minor change: add [changelog](https://mailu.io/master/contributors/workflow.html#changelog) entry file. Co-authored-by: Florent Daigniere <nextgens@freenetproject.org>
2866: Improve tokens (add ipranges) r=nextgens a=nextgens ## What type of PR? enhancement ## What does this PR do? Allow multiple IP addresses/networks to be set for tokens. ### Related issue(s) ## Prerequisites Before we can consider review and merge, please make sure the following list is done and checked. If an entry in not applicable, you can check it or remove it from the list. - [ ] In case of feature or enhancement: documentation updated accordingly - [x] Unless it's docs or a minor change: add [changelog](https://mailu.io/master/contributors/workflow.html#changelog) entry file. Co-authored-by: Florent Daigniere <nextgens@freenetproject.org>
2873: Fix issue #2811. Clamav Healthcheck created zombie processes r=mergify[bot] a=Diman0 ## What type of PR? bug-fix ## What does this PR do? The healthcheck of clamav results in zombie processes for some users. This PR addresses this issue. Now the healtcheck checks for the existence of the pid file of clamd and freshclam Note: [kill -0](https://unix.stackexchange.com/questions/169898/what-does-kill-0-do) can be used to check if a process exists and perform an error check. ### Related issue(s) - closes #2811 ## Prerequisites Before we can consider review and merge, please make sure the following list is done and checked. If an entry in not applicable, you can check it or remove it from the list. - [x] In case of feature or enhancement: documentation updated accordingly - [x] Unless it's docs or a minor change: add [changelog](https://mailu.io/master/contributors/workflow.html#changelog) entry file. Co-authored-by: Dimitri Huisman <diman@huisman.xyz>
2677: Apply DEFAULT_QUOTA to user creation admin ui page r=mergify[bot] a=PMExtra ## What type of PR? Feature ## What does this PR do? Apply `DEFAULT_QUOTA` settings to user creation admin ui page. ## Prerequisites Before we can consider review and merge, please make sure the following list is done and checked. If an entry in not applicable, you can check it or remove it from the list. - [ ] ~In case of feature or enhancement: documentation updated accordingly~ - [ ] ~Unless it's docs or a minor change: add [changelog](https://mailu.io/master/contributors/workflow.html#changelog) entry file.~ I'm sorry for that I'm not good at English to update the documentation. But this is not a completed new feature. `DEFAULT_QUOTA` is an existing configuration. I just completed the behaviors. Although this configuration was never documented. Co-authored-by: PM Extra <pm@jubeat.net> Co-authored-by: Alexander Graf <ghostwheel42@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR?
(Feature, enhancement, bug-fix, documentation)
What does this PR do?
Related issue(s)
Prerequisites
Before we can consider review and merge, please make sure the following list is done and checked.
If an entry in not applicable, you can check it or remove it from the list.