Fixed crash for collaborating containers #179
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a crash, that happens because of singleton state restoration in collaborating container that corrupts the singletons in the container to collaborate with.
The reproduction was found thanks to the fresh thoughts by @PaulTaykalo, as I was stuck on it.
The reproduction is outlined in
testThatItCanHandleSeparateContainersAndTheirCollaboration
inDipTests
.For some reason there appeared to be a crash under some really hard to meet conditions. It happened, when restoring state in defer in
collaboratingResolve
method.The code below reproduces the crash:
FYI: If Object and its registration are changed to the code below, the crash disappears: