Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed extension of ImplicitlyUnwrappedOptional #191

Merged
merged 2 commits into from
Jul 13, 2018

Conversation

Gruppio
Copy link
Contributor

@Gruppio Gruppio commented May 25, 2018

ImplicitlyUnwrappedOptional was already deprecated and it has been removed in swift 4.2
If you don't remove this extension Dip won't compile with Swift 4.2

It was deprecated and has been removed in swift 4.2
@ilyapuchka
Copy link
Collaborator

@Gruppio thanks, but this will be merged only when Swift 4.2 is released

@beefon
Copy link

beefon commented Jul 9, 2018

Is there a way to compile this conditionally?

@beefon
Copy link

beefon commented Jul 9, 2018

I assume this PR might be updated with

#if swift(<4.2)
extension ImplicitlyUnwrappedOptional: BoxType {		
   var unboxed: Any? {		
     return self ?? nil		
   }		
 }
#endif

@Gruppio
Copy link
Contributor Author

Gruppio commented Jul 9, 2018

I've add the check if swift is >= 4.1, so it is removed a warning in the current stable release ( 4.1 )

@ilyapuchka ilyapuchka merged commit d5b07b1 into AliSoftware:develop Jul 13, 2018
bvirlet pushed a commit to bvirlet/Dip that referenced this pull request Jul 26, 2018
* Removed extension of ImplicitlyUnwrappedOptional

It was deprecated and has been removed in swift 4.2

* Added Swift Version Check
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants