Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust Dip scheme to remove code coverage for Carthage Static Frameworks #194

Closed
wants to merge 1 commit into from

Conversation

kaosdg
Copy link

@kaosdg kaosdg commented Jun 6, 2018

... and add a new Testing scheme that has code coverage.

We're currently using Carthage static frameworks (https://github.com/Carthage/Carthage/blob/master/Documentation/StaticFrameworks.md) in our applications to increase app load times.

However, when Carthage builds Dip for static frameworks, the code coverage option on the Dip scheme leads to the following errors:

Undefined symbols for architecture x86_64:
  "___llvm_profile_runtime", referenced from:

By disabling code coverage on the scheme that Carthage builds, this issue is resolved.

I've added a separate Scheme solely for tests that enables code coverage, and adjusted the .travis.yml settings to use that.

@ilyapuchka
Copy link
Collaborator

ilyapuchka commented Jun 6, 2018

It seems to me as this is entirely Carthage issue or something that is not officially supported, but test coverage is something that can be sacrificed, so no need for extra scheme, it can be just turned off. Done in 33993df

@ilyapuchka ilyapuchka closed this Jun 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants