Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Swift 2.3 #184

Merged
merged 6 commits into from
Jul 12, 2016
Merged

Support Swift 2.3 #184

merged 6 commits into from
Jul 12, 2016

Conversation

ikesyo
Copy link
Collaborator

@ikesyo ikesyo commented Jun 21, 2016

This should be compatible with both Swift 2.2/Xcode 7.3 and Swift 2.3/Xcode 8.

@AliSoftware
Copy link
Owner

AliSoftware commented Jun 21, 2016

Thanks for the PR ! 👍

Wondering if I should really merge the last commit of your PR 80860843e066450b95ab09bb01960e5f2949c11d (the one containing that patch described in Quick/Nimble#302) or better wait for the next Xcode beta to see if it's fixed. Keeping that patch in the long run in the repo would seem hacky to me (because let's be honest, if I merge this patch commit I'll forget about it in a few weeks/months and never remove it later 😉)

@ikesyo
Copy link
Collaborator Author

ikesyo commented Jun 22, 2016

Thanks for your thought! I'm OK to wait for the next Xcode beta to remove the workaround. In the meantime I'll using the branch personally.

@ikesyo ikesyo changed the title Support Swift 2.3 [WIP] Support Swift 2.3 Jun 25, 2016
@AliSoftware
Copy link
Owner

AliSoftware commented Jul 10, 2016

Hey @ikesyo !

It seems like the workarounds (for linker & device codesigning) are no longer needed in Xcode 8 beta 2? Quick/Nimble#316

Could you thus please remove the workaround commits from this PR so we can move forward and merge a cleaner solution then? Thx!

@AliSoftware
Copy link
Owner

Note that we might also want to tweak the .travis.yml file by adding a build matrix so the CI check the build both with Xcode 7.3 and Xcode 8 (it is currently only using the osx_image: xcode7.3.

You can find some inspiration on this .travis.yml file on my other library where I already did that kind of configuration.

@ikesyo ikesyo force-pushed the swift2.3 branch 2 times, most recently from 0445f0d to 66e8ead Compare July 11, 2016 00:00
@ikesyo ikesyo force-pushed the swift2.3 branch 2 times, most recently from 3b925ba to 51cef8e Compare July 11, 2016 00:25
…odebuild`

That can't be used on Xcode 8 (`platform=macOS` should be used instead). So removes `platform=` from `-destination` option and specifies `-sdk` option instead.
@ikesyo ikesyo changed the title [WIP] Support Swift 2.3 Support Swift 2.3 Jul 12, 2016
@ikesyo
Copy link
Collaborator Author

ikesyo commented Jul 12, 2016

Travis now supports Xcode 8 beta 2: https://twitter.com/travisci/status/752704816116293632. But the iOS tests are randomly failed as seen in the following:

▸ Signing /Users/travis/Library/Developer/Xcode/DerivedData/OHHTTPStubs-gozjzzlydcppgdbvdohewsnafzwl/Build/Products/Debug-iphonesimulator/OHHTTPStubs\ iOS\ Fmk\ Tests.xctest
** TEST FAILED **
rake aborted!
Command failed with status (65): [set -o pipefail && xcodebuild -workspace O...]

@AliSoftware
Copy link
Owner

Sadly that happens more and more on Travis lately, builds taking ages to start and builds randomly failing, while they pass perfectly locally.
Given that we now have 8 parallel builds for each PR now (because of the build matrix testing the 4 targets, each in Xcode 7 and 8) there are more chances that one of those 8 randomly fail because of that.

Not sure if I can do anything about it. I could deactivate my timing tests for all but one build, that would probably help as those expect the response to be in a specific time window to ensure the given responseTime is respected… but if the Travis VM is too solicited and slow that doesn't help. But the most build fails I've seen lately are not because of them but more because of Travis failing to launch th Xcode test command, so I'm puzzled…

I just relaunched the Travis build that failed and hope it will pass this time, until I have more time to investigate that Travis bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants