Added isMethodHEAD to swift helpers #294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AliSoftware
approved these changes
Nov 15, 2018
|
Thanks! Appreciate the quick turnaround on this 🎉 I ran the tests locally multiple times and they were fine, Travis can be a bit weird sometimes |
|
hey @AliSoftware are you planning to release new version of OHHTTPStubs anytime soon? I need this PR merged for the project I'm working on :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description
Hi there! I added the http isMethodHEAD and updated the test to reflect that :)
Motivation and Context
I needed to mock the HEAD http call in the project I'm working on and it wasn't available in OHHTTPStubsTestBlock!