Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating for 9.1.0 release. #337

Merged
merged 1 commit into from Dec 2, 2020
Merged

Updating for 9.1.0 release. #337

merged 1 commit into from Dec 2, 2020

Conversation

jeffctown
Copy link
Collaborator

Updating version in Changelog.
Updating Example projects.
Updating podspec.

Checklist

  • I've checked that all new and existing tests pass
  • I've updated the documentation if necessary
  • I've added an entry in the CHANGELOG to credit myself

Description

Updating for release 9.1.0.

Updating version in Changelog.
Updating Example projects.
Updating podspec.
Copy link

@Kaspik Kaspik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!


PODFILE CHECKSUM: 7da7c441ea9ff6f06b633c908b7a7294805f5602

COCOAPODS: 1.7.5
COCOAPODS: 1.9.3
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1.9.3 is not compatible with Ruby 2.7.0, is there a reason why not to use 1.10.0? :)

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a good question. Not sure it matters here because it's on the Podfile.lock of the example projects (and it shouldn't prevent users who use CO 10.0 to pod install on the example projects if they wanted to anyway) so it's not a restriction on the pod itself or its podspec. But good to keep in mind (I didn't know about the ruby versions compatibility limitation with 1.9.3)

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ohh, right, example - yeah it doesn't then :)

Copy link
Owner

@AliSoftware AliSoftware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jeffctown jeffctown merged commit 12f1966 into master Dec 2, 2020
@jeffctown jeffctown deleted the release/9.1.0 branch December 2, 2020 09:22
@jeffctown
Copy link
Collaborator Author

I tagged this for you @Kaspik . Thanks for reminding me!

@Kaspik
Copy link

Kaspik commented Dec 2, 2020

Thank youuu, last XCode 12 warning is fixed now! 🎉

@AliSoftware
Copy link
Owner

Thanks for taking care of this @jeffctown ! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants