Use the ivar directly in initialization #66
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AliSoftware
added a commit
that referenced
this pull request
Jul 22, 2014
|
Thx! |
vladzz
pushed a commit
to vladzz/OHHTTPStubs
that referenced
this pull request
Sep 29, 2014
# By Olivier Halligon (19) and Hermes Pique (1) # Via AliSoftware (1) and others * 'master' of https://github.com/AliSoftware/OHHTTPStubs: Fix typos Updated README Bump version to 3.1.5 Adding XCTestExpectation subspec [XCTest RetroCompat] No need to lock the _expectations array when we fulfill an expectation, simply decrementing the counter is enough and faster than useless locking Renamed secret methods to BETTER_FAILURE_EXPECTATIONS to have a more private name Better Failure Locations (actually shows error on the expectationWithDescription & waitForExpectationsWithTimeout lines :-)) Using much faster and efficient OSAtomicCompareAndSwap instead of @synchronize) --> We now avoid locking the whole object with @synchronize each time, because locking the array each time with @synchronize was slowing down the unit tests a lot — making the timeout expire due to that extra time used for locking Prevent redefinition of XCTestExpectation in Xcode6… for OSX SDK 10.10 too (was previously only prevented for iOS SDK 8.0) + Validate Build Settings + Increased timing tolerance Fix demo scheme Refactor to migrate to XCTestExpectation (with my own implementation for Xcode5 so it is still compatible) Fixing pbxproj small typos Code migration to XCTest + Regeneration of the Xcode project to start from a clean slate (because it seemed a bit corrupted maybe?) Updated CHANGELOG.md Bump pod version Fix issue AliSoftware#65 Bump pod version Increased Unit Tests timing tolerence to avoid random test failures Updated Travis-CI conf to avoid 'brew upgrade' error. Using pre-installed xctool instead. Merge Pull Request AliSoftware#66 Conflicts: OHHTTPStubs/OHHTTPStubs.xcodeproj/project.pbxproj OHHTTPStubs/OHHTTPStubs.xcodeproj/xcshareddata/xcschemes/OHHTTPStubs Mac.xcscheme OHHTTPStubs/OHHTTPStubs.xcodeproj/xcshareddata/xcschemes/OHHTTPStubs iOS.xcscheme OHHTTPStubs/UnitTests/AsyncSenTestCase.h OHHTTPStubs/UnitTests/AsyncSenTestCase.m OHHTTPStubs/UnitTests/Test Suites/AFNetworkingTests.m OHHTTPStubs/UnitTests/Test Suites/NSURLConnectionDelegateTests.m OHHTTPStubs/UnitTests/Test Suites/NSURLSessionTests.m OHHTTPStubsDemo/OHHTTPStubsDemo.xcodeproj/xcshareddata/xcschemes/OHHTTPStubs iOS Demo.xcscheme
AliSoftware
added a commit
that referenced
this pull request
Nov 3, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to prevent calling the custom setter inside initialization which broadcasts KVO notifications.