Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adds audio_on option (#434) #484

Merged
merged 1 commit into from
Sep 29, 2022

Conversation

hamin-lee
Copy link
Contributor

@hamin-lee hamin-lee commented Dec 13, 2021

Resolves #434

  1. adds audio_on argument on demo.py
  2. if user adds --audio_on as argument, it will generate another mp4 file with name: <result_vid_name>-with-audio.mp4
  3. adds moviepy library and updates versions of numpy, imageio, scikit-image

1. adds audio_on argument on demo.py
2. if user adds --audio_on argument it will generate another mp4 file with <result_vid_name>-with-audio.mp4
3. adds moviepy library and updates versions of numpy, imageio, scikit-image
@graphemecluster
Copy link
Contributor

Hello, I am the author of demo.ipynb. To make things consistent, I think you'd better use FFmpeg from ffmpy instead:

from ffmpy import FFmpeg
FFmpeg(inputs={'temp.mp4': None, opt.driving_video: None}, outputs={opt.result_video: '-c copy -y'}).run()

And please mimsave the video as another name like temp.mp4 and remove the file afterwards. 👍

@@ -121,10 +123,12 @@ def normalize_kp(kp):
help="Set frame to start from.")

parser.add_argument("--cpu", dest="cpu", action="store_true", help="cpu mode.")


parser.add_argument("--audio_on", dest="audio_on", action="store_true", help="option to have audio on." )
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
parser.add_argument("--audio_on", dest="audio_on", action="store_true", help="option to have audio on." )
parser.add_argument("--audio", dest="audio", action="store_true", help="copy audio to output from the driving video")

@AliaksandrSiarohin AliaksandrSiarohin merged commit 48174e1 into AliaksandrSiarohin:master Sep 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sound doesn't downl
3 participants