Resolve configuration loading issues #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This issue was caused by logic of click() handlers on checkbox elements, which produces different results depending on whether the DOM element toggle or click handler is executed first. Resolved by using change() handlers instead.
Timeout allowed config values to load because without it, a race condition could occur where events get fired on elements before they are defined. Resolved by ordering DOM element appends before config loading.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves issues with saved configurations not being properly applied on load. The root cause was race conditions occurring in two places:
Race condition 1 was resolved by changing use of jQuery
click()tochange()handlers for checkboxes, which is guaranteed to fire after the DOM element is toggled.Race condition 2 was resolved by ordering the addition of the main menu DOM elements to occur before associated event handlers are attached. This also removes the need to load config with a timeout.